-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Annotation] A push button can have no action (bug 1778692) #15153
Conversation
src/display/annotation_layer.js
Outdated
if (this.enableScripting && this.hasJSActions && container.lastChild) { | ||
const linkElement = container.lastChild; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we could, ever so slightly, simplify things by getting the element just once:
if (this.enableScripting && this.hasJSActions && container.lastChild) { | |
const linkElement = container.lastChild; | |
const linkElement = container.lastChild; | |
if (linkElement && this.enableScripting && this.hasJSActions) { |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4206ac00333a622/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5b2e9742bbe9791/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5b2e9742bbe9791/output.txt Total script time: 26.41 mins
Image differences available at: http://54.241.84.105:8877/5b2e9742bbe9791/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4206ac00333a622/output.txt Total script time: 28.46 mins
Image differences available at: http://54.193.163.58:8877/4206ac00333a622/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9c98ef4cb509171/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f6e602956c04184/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9c98ef4cb509171/output.txt Total script time: 22.47 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f6e602956c04184/output.txt Total script time: 22.57 mins
|
…e, a=dmeehan Backport of upstream commit: mozilla/pdf.js#15153 Differential Revision: https://phabricator.services.mozilla.com/D151923
No description provided.